Does nobody else think the responses from the person who wrote the code read like the usual sycophantic “you’re absolutely right!” tone you get from AI these days?
>After reviewing the core defrag logic myself, I've come to a conclusion that it's AI slop.
Will call it a human slop. AI may've given them some code but they certainly haven't use it fully. I uploaded the defrag.c in ChatGPT asking to review on performance/correctness/safety and pointed the sames issues as you (alongside bunch of others but not interested at the moment to review them).
Sigh. Piss poor engineering, likely by humans. For the love of god, do atomic updates by duplicating data first such as in a move-out-of-the-way-first strategy before doing metadata updates. And keep a backup of metadata at each point of time to maximize crash consistency and crash recovery while minimizing the potential for data loss. An online defrag kernel module would likely be much more useful but I don't trust them to be able to handle such an undertaking.
If a user has double storage available, it's probably best to do the old-fashioned "defrag" by single-threaded copying all files and file metadata to a newly-formatted volume.
That last paragraph sums up the ZFS defrag procedure at one shop I worked at. Buy new disks and send/receive the pool.
At our size and use case the timing was usually close to perfect. The pools were getting close to full and fragmented as larger disks became inexpensive.
Does nobody else think the responses from the person who wrote the code read like the usual sycophantic “you’re absolutely right!” tone you get from AI these days?
There at least 2 AIs.
>We prioritized simplicity and correctness first, and plan to incrementally introduce performance optimizations in future iterations.
Sir, this is a correctness issue.
>After reviewing the core defrag logic myself, I've come to a conclusion that it's AI slop.
Will call it a human slop. AI may've given them some code but they certainly haven't use it fully. I uploaded the defrag.c in ChatGPT asking to review on performance/correctness/safety and pointed the sames issues as you (alongside bunch of others but not interested at the moment to review them).
Talk about a baptism of fire for the dev.
Seems like they are very new to tbings and didn't expect it to be adopted, but were hoping for a bit of feedback.
Sigh. Piss poor engineering, likely by humans. For the love of god, do atomic updates by duplicating data first such as in a move-out-of-the-way-first strategy before doing metadata updates. And keep a backup of metadata at each point of time to maximize crash consistency and crash recovery while minimizing the potential for data loss. An online defrag kernel module would likely be much more useful but I don't trust them to be able to handle such an undertaking.
If a user has double storage available, it's probably best to do the old-fashioned "defrag" by single-threaded copying all files and file metadata to a newly-formatted volume.
That last paragraph sums up the ZFS defrag procedure at one shop I worked at. Buy new disks and send/receive the pool.
At our size and use case the timing was usually close to perfect. The pools were getting close to full and fragmented as larger disks became inexpensive.